fix: unbreak upload retries (two bugs) #71
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UploadTask
retries seem to be broken and i'm not sure how long ago they brokefirst problem
the first problem is in
tasks/base.py
: celery'sapply_async()
function takes anoptions
dict which may have a"headers"
key. i believe it'sNone
by default (docs aren't explicit) and as a result we attempt**None
which errors with:the fix for this problem is straightforward
second problem
second problem was recently introduced (by me). by changing
self.retry()
toself.retry(args=args, kwargs=kwargs)
, i excluded therepoid
andcommitid
arguments which led to an exception incelery_task_router.py
:strangely, the clearest fix for a missing positional argument is... to add it to
kwargs
. regularargs
are not plumbed through tocelery_task_router.py
, and i tried to plumb them through but i just don't have the tools (read: static type system) to be confident i caught all the task operations that need to be updated.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.